-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes + add TestAutoSpecialVolume (=underwater) #237
Conversation
…pack demo has smk, xmas demo has a flic)
@@ -1795,7 +1795,11 @@ void LoadCar(char* pCar_name, tDriver pDriver, tCar_spec* pCar_spec, int pOwner, | |||
FatalError(kFatalError_FileCorrupt_S, pCar_name); | |||
} | |||
if (*pDriver_name != '\0') { | |||
#if defined(DETHRACE_FIX_BUGS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add a comment documenting what the bug is that we are fixing?
for (i = 0; i < len; i++) { | ||
c = pS[i]; | ||
#if defined(DETHRACE_FIX_BUGS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a comment documenting the original bug behavior?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OG game (carm95.exe at least) does not do this.
It keeps the original key and does not decode the comments with the alternative key.
I'll add this as a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that would be great, thanks.
if (gEncryption_method == 1) { | ||
if (c == '\t') { | ||
c = 0x80; | ||
c = 0x9f; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, good spotting. Dont know how I got encryption methods round the wrong way! 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
… a bug" This reverts commit 3345649.
BrXXX
functions/macro'sDecodeLine2
+tools/decode_datatxt.py
so the coments become readableStopGroovidelic
Fixes No difference in handling underwater #194
DrawTheGlow
.This change might be a bit controversial as it might introduces more crashes.
But I think this is good so we can find the bug sooner.
Either case, the crash in
SmokeLine
happens on my system too with stubbing this function.--full-screen
command line option to start DethRace in full screen modeFixes Cursor position scaled incorrectly in
-hires
mode #218IWANTTOFIDDLE
. Tested with Carmageddon 1 full game data by encoding/decoding the data a few times.